chore: update this project to use the generator #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Oct 9, 2020
scripts/rollup.config.js
Outdated
Comment on lines
19
to
21
| const mainBuilds = generate(Object.assign({input: 'lib/index.js', distName: 'mux'}, shared)).builds; | ||
| const mp4Builds = generate({input: 'lib/mp4/index.js', distName: 'mux-mp4'}).builds; | ||
| const flvBuilds = generate({input: 'lib/flv/index.js', distName: 'mux-flv'}).builds; |
There was a problem hiding this comment.
What's being used for the UMD name here? Looks like previously it was set to muxjs.
There was a problem hiding this comment.
updated to muxjs
brandonocasey
force-pushed
the
chore/generator
branch
2 times, most recently
from
cd68273
to
613081e
Compare
brandonocasey
commented
Dec 2, 2020
| @@ -81,9 +81,11 @@ var makeMdatFromCaptionPackets = function(packets) { | |||
| mdat.push(sei.escapedRBSP.length + 1); // nal length | |||
| mdat.push(0x06); // declare nal type as SEI | |||
| // SEI message | |||
| sei.escapedRBSP.forEach(function(byte) { | |||
| for (var i = 0; i < sei.escapedRBSP.length; i++) { | |||
There was a problem hiding this comment.
small change as ie 11 does not support forEach on a Uint8Array
brandonocasey
commented
Dec 2, 2020
| @@ -2635,7 +2637,7 @@ QUnit.test('Cea608Stream will log errors, not throw an exception', function(asse | |||
| 'warnings were logged to the console' | |||
| ); | |||
|
|
|||
| window.console.error = originalConsole; | |||
| console.error = originalConsole; | |||
There was a problem hiding this comment.
nodejs support
gkatsev
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #351 as that is a required, but easily separate piece to standardizing this project.has been mergedChanges
test/metadata-stream.test.jsas it will take some work to get it working with rollup. See TODO below.TODO (in another pull request):
Add a plugin to unit test theDone via rollup-plugin-worker-factoryWebWorkercode intest/metadata-stream.test.jsthat I commented out as it relies on browserify.lintscript by removing the:from the front.pre-commithook to runlint-stagedagain by removing the:in-front of it.