feat(CaptionStream): add flag to turn off 708 captions #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This options flow through the transmuxer into CaptionStream.
gkatsev
added a commit
to videojs/http-streaming
that referenced
this pull request
Jan 15, 2021
Add cc708 as a VHS option to turn off 708 captions. This PR depends on videojs/mux.js#365
gesinger
reviewed
Jan 19, 2021
lib/m2ts/caption-stream.js
Outdated
|
|
||
| CaptionStream.prototype.init.call(this); | ||
|
|
||
| // cc708 flag, default to true | ||
| this.cc708_ = typeof options.cc708 === 'boolean' ? options.cc708 : true; |
There was a problem hiding this comment.
I think it might be better to add a bit more description. Maybe something like include708Captions or parse708Captions.
gesinger
reviewed
Jan 19, 2021
lib/m2ts/caption-stream.js
Outdated
|
|
||
| CaptionStream.prototype.init.call(this); | ||
|
|
||
| // cc708 flag, default to true | ||
| this.cc708_ = typeof options.cc708 === 'boolean' ? options.cc708 : true; |
There was a problem hiding this comment.
Might be worth changing the name to be a bit more descriptive. Maybe include708Captions or parse708Captions.
gkatsev
commented
Jan 19, 2021
lib/m2ts/caption-stream.js
Outdated
| this.parse708captions_ = typeof options.parse708captions === 'boolean' ? | ||
| options.parse708captions : | ||
| true; | ||
| this.parse708captions_ = true; |
There was a problem hiding this comment.
this is to demonstrate the test failing
gesinger
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This options flow through the transmuxer into CaptionStream.