feat: add a nodejs binary for transmux via command line #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
feat/bin-ts-fmp4
branch
from
8cf8a53
to
edad7c1
Compare
gkatsev
reviewed
Jan 25, 2021
Comment on lines
+35
to
+38
| } else if ((/^--help|-h$/).test(arg)) { | ||
| showHelp(); | ||
| process.exit(0); | ||
| } else if ((/^--debugger|-d$/).test(arg)) { |
There was a problem hiding this comment.
we currently error out if muxjs-transmux is run without arguments, we probably should default to showHelp()
|
The timing issues could be because I set base media decode time to a default value of 100000 |
|
Actually I think you mean the duration of the file when playing back? That happens because we set duration to |
|
Yeah, of the generated mp4 file. |
gkatsev
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.