parse edts box implemented #375
Conversation
|
Hi @gkatsev @gesinger @joeyparrish |
There was a problem hiding this comment.
Thank you for the PR @nklhrstv !
Looks good judging by the layout I see in https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap2/qtff2.html#//apple_ref/doc/uid/TP40000939-CH204-32975
One minor comment.
lib/tools/mp4-inspector.js
Outdated
| i; | ||
| for (i = 8; entryCount; i += 12, entryCount--) { | ||
| result.edits.push({ | ||
| segmentDuration: view.getUint32(i), |
There was a problem hiding this comment.
looking at the mp4 spec it seems like we need to look at result.version and if result.version is 0 then segmentDuration and mediaTime will 32 bit and if result.version is 1 then segmentDurationandmediaTime` will be 64 bit.
There was a problem hiding this comment.
for an example of grabbing 64 bit values (i know js doesn't actually support that many bits for numbers, but we can still get them up to 52 bits) see https://github.com/videojs/mux.js/blob/main/lib/tools/parse-sidx.js#L20-L21
There was a problem hiding this comment.
What about BigInt? Ive used .getBigUint64.
There was a problem hiding this comment.
What is the minimum supported node version for this library?
There was a problem hiding this comment.
Ive added 64 bit test case.
should be all good now
Hi,
Ive implemented parsing for edts atom by following this spec