Safari 12 workaround for array.reverse caching #377
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Reverse a copy of the axis array as a workaround for a bug introduced in Safari 12 (https://bugs.webkit.org/show_bug.cgi?id=188794)
Why is this Pull Request needed?
Safari 12 introduced a bug where calling reverse on an array will cache the reverse value, causing captions to jump up and down.
To reproduce the bug run the following:
notice that even though the array is being instantiated, the value is reversed even before
reverse
is called.The following screenshot shows the bug in action: