Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add general error/warn/debug log events #391

Merged
merged 3 commits into from
Jul 2, 2021
Merged

feat: add general error/warn/debug log events #391

merged 3 commits into from
Jul 2, 2021

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Jul 1, 2021 •
edited
Loading

Report warnings, debug, and error information via events.

gesinger
gesinger reviewed Jul 2, 2021
View reviewed changes
lib/codecs/adts.js Outdated Show resolved Hide resolved
lib/mp4/transmuxer.js Outdated Show resolved Hide resolved
brandonocasey and others added 2 commits July 2, 2021 11:00
@brandonocasey
use typeof
cfa40cf
@brandonocasey @gesinger
Update lib/mp4/transmuxer.js
e5d8d84 
Co-authored-by: Garrett Singer <gesinger@gmail.com>
@brandonocasey brandonocasey mentioned this pull request Jul 2, 2021
Merged
@brandonocasey brandonocasey merged commit 6588d48 into main Jul 2, 2021
@brandonocasey brandonocasey deleted the feat/log-events branch July 2, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gesinger gesinger gesinger approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brandonocasey @gesinger @gkatsev