fix: replace indexOf with typedArrayIndexOf for IE11 support #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Jul 5, 2022
pszemus
reviewed
Jul 6, 2022
Comment on lines
+1
to
+19
| // IE11 doesn't support indexOf for TypedArrays. | ||
| // Once IE11 support is dropped, this function should be removed. | ||
| var typedArrayIndexOf = (typedArray, element, fromIndex) => { | ||
| if (!typedArray) { | ||
| return -1; | ||
| } | ||
|
|
||
| var currentIndex = fromIndex; | ||
|
|
||
| for (; currentIndex < typedArray.length; currentIndex++) { | ||
| if (typedArray[currentIndex] === element) { | ||
| return currentIndex; | ||
| } | ||
| } | ||
|
|
||
| return -1; | ||
| }; | ||
|
|
||
| module.exports = { typedArrayIndexOf }; |
There was a problem hiding this comment.
Function does not support negative fromIndex whereas indexOf does. Let's hope nobody uses it that way.
I didn't change PRIV for now because the behavior is slightly different, in that it takes a subarray of the typed array from a non-existent area in the event that 0 is not found. Although the behavior is not great, I didn't want to potentially break anything and the logic becomes a bit more complex with |
pszemus
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.