Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display time tooltip for mobile when sliding #7598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Display time tooltip for mobile when sliding #7598

wants to merge 1 commit into from

Conversation

Chocobozzz
Copy link
Contributor

Hi :)

Description

Display time tooltip when sliding on mobile. Without this, it's difficult to move to the desired timestamp on android/ios.

Specific Changes proposed

Enable timeTooltip for mobile and adapt CSS to always display it when sliding.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Jan 7, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.24%. Comparing base (eeda26f) to head (91e1667).
Report is 325 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7598      +/-   ##
==========================================
- Coverage   80.24%   80.24%   -0.01%     
==========================================
  Files         116      116              
  Lines        7325     7324       -1     
  Branches     1771     1770       -1     
==========================================
- Hits         5878     5877       -1     
  Misses       1447     1447

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chocobozzz Chocobozzz mentioned this pull request Jan 10, 2022
Closed
@stale
Copy link

stale bot commented Apr 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Apr 19, 2022
@Chocobozzz
Copy link
Contributor Author

bump

@stale stale bot removed the outdated Things closed automatically by stalebot label Apr 19, 2022
@mister-ben
Copy link
Contributor

The current behaviour to hide was added in #4185, in 2017. On a modern Android Chrome the tooltips look fine with this PR, but I'm not sure what problems needed to be avoided back then.

@gkatsev
Copy link
Member

gkatsev commented Apr 19, 2022

It was turned off because the tooltips definitely weren't working right back then on touch (mobile) devices.

@Chocobozzz
Copy link
Contributor Author

Chocobozzz commented Apr 20, 2022 •
edited
Loading

It was turned off because the tooltips definitely weren't working right back then on touch (mobile) devices.

Do you remember with what OS/device? I could try to test this PR on them using browser stack

@gkatsev
Copy link
Member

gkatsev commented Apr 20, 2022

Unfortunately, I do not remember. I'm also not sure that testing via browserstack would be reliable enough here.

@misteroneill misteroneill added the patch This PR can be added to a patch release. label May 23, 2022
@endnch
Copy link

endnch commented Nov 3, 2022

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs: testing patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Chocobozzz @mister-ben @gkatsev @endnch @misteroneill