feat: add an option to suppress out of dom warning #7808
Conversation
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Thanks for the PR and sorry about the delay in addressing it!
I don't have anything strongly against it, but I wonder if it's needed. Your use case makes sense, but isn't logging a warning the right thing to do?
A warning doesn't mean action needs to be taken, it means there is a condition which may deserve attention, but may also be ignorable.
|
I don't disagree that the warning should be generated by default if the element is not in the dom, but there should also be a way to suppress the warning if you have the element out of the dom on purpose. Once you start ignoring warnings because you can't suppress them then you're going to start ignoring warnings that you should actually be correcting. Perhaps instead of introducing a new option here we can instead change the logic so if there is a VIDEO element out of dom then the warning is generated but if there is an AUDIO element out of the dom then no warning is generated? |
misteroneill
force-pushed
the
main
branch
2 times, most recently
from
c1898b4
to
4f8227d
Compare
Description
Adds an option to suppress the "The element supplied is not included in the DOM" warning for intentionally detached video/audio elements.
Use case: video.js wrapping html5 audio element but not using video.js UI and video.js wrapping html5 video rendered into a WebGL scene.
Specific Changes proposed
add a player option that, when set to true, suppresses the warning
Requirements Checklist