Add a player option keepTimeTooltipInSeekBar to prevent time tooltip overflow #7913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## main #7913 +/- ##
==========================================
- Coverage 80.94% 80.83% -0.11%
==========================================
Files 116 116
Lines 7467 7479 +12
Branches 1816 1821 +5
==========================================
+ Hits 6044 6046 +2
- Misses 1423 1433 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
misteroneill
force-pushed
the
main
branch
2 times, most recently
from
c1898b4
to
4f8227d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally, the time tooltip was allowed to overflow into the seek bar, which is fine in general but for those who want to customize their skins, allowing overflow is not necessarily a good idea.
This PR allows developers to easily keep the time tooltip inside the seek bar with a single player configuration option.
Specific Changes proposed
Add a player option
keepTimeTooltipInSeekBarwhich, if set totrue, prevents the time tooltip overflow the seek barRequirements Checklist
Gallerys
CSS Skins