Fix 8141: fix npm run build sass icon failure which prevents types from being built #8217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## main #8217 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 112 112
Lines 7402 7402
Branches 1785 1785
=======================================
Hits 6078 6078
Misses 1324 1324 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Is there any update on this one? |
|
Alas I have reason to believe that this PR won't fix the issue. |
|
Hey @zorent-zebra thanks for the PR! I've converted this to a draft based on the last comment. Feel free to update when you can and mark it ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix angular not building in video.js version 8 reported in #8141
Specific Changes proposed
sass was erroring out for me when running
npm run buildon the stepsbuild:css:cdnandbuild:css:default.This seemed to cause the build not to get to
build:types.In my local 8.2.1 video.js in angular, there is no file
./dist/types/video.d.ts.My guess is that it's due to this build failure.
I haven't checked whether this affects building using yarn....
We don't use yarn.
Requirements Checklist