fix: add additional and remove unused error const #8656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8656 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 113 113
Lines 7636 7636
Branches 1835 1835
=======================================
Hits 6316 6316
Misses 1320 1320 ☔ View full report in Codecov by Sentry. |
dzianis-dashkevich
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add and remove some error constants specific to
videojs-contrib-emeerrors.Specific Changes proposed
Remove the keysystem specific errors as the keysystem is now passed as error metadata and add errors for
removeandloadcalls on theMediaKeySessionRequirements Checklist