Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update VHS to 2.16.3 #8677

Merged
merged 3 commits into from
May 28, 2024
Merged

feat: Update VHS to 2.16.3 #8677

merged 3 commits into from
May 28, 2024

Conversation

MCab93
Copy link

@MCab93 MCab93 commented Apr 8, 2024

Description

Added support for newer @videojs/http-streaming versions.

Expected outcome is release of video.js v7.21.6.

Copy link

welcome bot commented Apr 8, 2024

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for zesty-marshmallow-73319e ready!

Name Link
🔨 Latest commit 30701bc
🔍 Latest deploy log https://app.netlify.com/sites/zesty-marshmallow-73319e/deploys/664fa96932e08f0008240d66
😎 Deploy Preview https://deploy-preview-8677--zesty-marshmallow-73319e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kikklop
Copy link

kikklop commented May 23, 2024

@mister-ben Hi, we also have this same issue. Could you please try merge it? It will really help us to resolve our issues. Thanks

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label May 23, 2024
@mister-ben mister-ben changed the title feat: added support for newer videojs/http-streaming feat: Update VHS to 2.16.3 May 24, 2024
Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov keeps facing to upload but this change won't affect coverage.

@mister-ben mister-ben merged commit 3a128d1 into videojs:7.x May 28, 2024
11 of 12 checks passed
Copy link

welcome bot commented May 28, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@mister-ben mister-ben removed the needs: LGTM Needs one or more additional approvals label May 28, 2024
@mister-ben
Copy link
Contributor

Thanks @MCab93. v7.21.6 is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants