fix: Support MacOS trackpad with tap-to-click #8700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8700 +/- ##
==========================================
+ Coverage 83.00% 83.62% +0.61%
==========================================
Files 120 120
Lines 7996 7998 +2
Branches 1926 1927 +1
==========================================
+ Hits 6637 6688 +51
+ Misses 1359 1310 -49 ☔ View full report in Codecov by Sentry. |
|
Just wanted to note that on my laptop with 14.2.1 sonoma, I get button=0 and buttons=1. Going to update it and see if it changes. |
|
Upgrading the macos didn't change the behavior. Setting up logging in the method, 95% of the time it does 0,1, but sometimes it is 0,0. |
gkatsev
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a MacOS trackpad is using "tap to click", the tap/click was being ignored by the seek bar sometimes, so there would be no seek. This is because the
mousedownMouseEvent has{button: 0, buttons: 0}or{button: 0, buttons: 1}inconsistently.Specific Changes proposed
(event.type === 'mousedown' && event.button === 0 && event.buttons === 0)a click.mousemoveevent.Fixes #8691, #7736
Requirements Checklist