feat: add browser.IS_CHROMECAST_RECEIVER and class name for CSS targeting on a Chromecast receiver where Video.js is used #8703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a Chromecast receiver where Video.js is used
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8703 +/- ##
=======================================
Coverage 83.00% 83.01%
=======================================
Files 120 120
Lines 7996 7999 +3
Branches 1926 1929 +3
=======================================
+ Hits 6637 6640 +3
Misses 1359 1359 ☔ View full report in Codecov by Sentry. |
dzianis-dashkevich
approved these changes
Apr 22, 2024
mister-ben
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some people may want to use Video.js as part of their Chromecast receiver application - particularly for UI customization. This PR builds on #8676 by adding feature detection for a Chromecast receiver context.
I did not test this on a cast device as I do not own one!
Specific Changes proposed
browser.IS_CHROMECAST_RECEIVERbooleanvjs-device-chromecast-receiverclass name for players running on a Chromecast receiver deviceRequirements Checklist