fix: Ensure aria-labelledby values in track settings are valid #8711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8711 +/- ##
=======================================
Coverage 83.00% 83.00%
=======================================
Files 120 120
Lines 7996 7996
Branches 1926 1926
=======================================
Hits 6637 6637
Misses 1359 1359 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes new text track settings, so that
aria-labelledbyattributes contain only valid attributes. Currently there is one invalid id, and two els with duplicate ids.Fixes #8708
Specific Changes proposed
Updates text-track-settings.js to set the
idproperty to an empty string where there is nolabel, only alegendelement.Adds tests to validate aria-labelled by values.
Requirements Checklist