Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use URL API #8716

Merged
merged 4 commits into from
May 3, 2024
Merged

refactor: use URL API #8716

merged 4 commits into from
May 3, 2024

Conversation

mister-ben
Copy link
Contributor

Description

Replaces some now unnecessary fallbacks with the standard URL API.
parseUrl new returns an actual URL instead of a URL-like object.
Updates tests slightly: getAbsoluteURL() to match URL's behaviour with trailing slashes, and use a URL object in the cross origin tests.
Adds a test for getAbsoluteURL() with a relative URL

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (cb76a24) to head (0679fdb).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8716      +/-   ##
==========================================
- Coverage   83.00%   82.97%   -0.04%     
==========================================
  Files         120      120              
  Lines        7998     7978      -20     
  Branches     1927     1921       -6     
==========================================
- Hits         6639     6620      -19     
+ Misses       1359     1358       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amtins
amtins reviewed Apr 30, 2024
View reviewed changes
test/unit/utils/url.test.js Outdated Show resolved Hide resolved
@mister-ben mister-ben merged commit 992af3b into videojs:main May 3, 2024
11 checks passed
@kerasus kerasus mentioned this pull request Jun 21, 2024
Open
@Bitti09 Bitti09 mentioned this pull request Jun 21, 2024
Closed
@kerasus kerasus mentioned this pull request Jun 28, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 2, 2024
Open
@kerasus kerasus mentioned this pull request Jul 4, 2024
Open
@ChaosEngine ChaosEngine mentioned this pull request Jul 9, 2024
Open
@kerasus kerasus mentioned this pull request Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amtins amtins amtins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mister-ben @amtins