feat: refactor error consts #8719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8719 +/- ##
==========================================
+ Coverage 83.00% 84.26% +1.25%
==========================================
Files 120 120
Lines 7998 9197 +1199
Branches 1927 2343 +416
==========================================
+ Hits 6639 7750 +1111
- Misses 1359 1447 +88 ☔ View full report in Codecov by Sentry. |
misteroneill
approved these changes
May 6, 2024
dzianis-dashkevich
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor error constants to a generic streaming set.
Specific Changes proposed
Remove unused error constants and replace with generic streaming errors.
Requirements Checklist