Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Update translations needed #8725

Merged
merged 1 commit into from
May 30, 2024
Merged

chore(docs): Update translations needed #8725

merged 1 commit into from
May 30, 2024

Conversation

mohammadmansour200
Copy link
Contributor

@mohammadmansour200 mohammadmansour200 commented May 9, 2024 •
edited
Loading

Description

Added missing Arabic translation, but forgot to remove that from this file, sorry about that :)

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov Codecov
Copy link

codecov bot commented May 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (7b0aede) to head (e5397fb).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8725   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files         120      120           
  Lines        7995     7995           
  Branches     1924     1924           
=======================================
  Hits         6648     6648           
  Misses       1347     1347

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben changed the title Added missing Arabic translation, but forgot to remove that from this file chore(docs): Update translations needed May 23, 2024
@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label May 24, 2024
@adrums86 adrums86 merged commit 85b47ce into videojs:main May 30, 2024
8 of 13 checks passed
@welcome Welcome
Copy link

welcome bot commented May 30, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mister-ben mister-ben mister-ben approved these changes

@adrums86 adrums86 adrums86 approved these changes

Assignees
No one assigned
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohammadmansour200 @mister-ben @adrums86