Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Firefox warnings about deprecated event props #8736

Merged
merged 2 commits into from
May 30, 2024

Conversation

mister-ben
Copy link
Contributor

Description

Adds mozPressure and mozInputSource to the list of event properties not to cover, as reading them triggers deprecation warnings.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (978731e) to head (6cfefb1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8736      +/-   ##
==========================================
- Coverage   83.15%   83.14%   -0.01%     
==========================================
  Files         120      120              
  Lines        7995     7994       -1     
  Branches     1924     1922       -2     
==========================================
- Hits         6648     6647       -1     
  Misses       1347     1347              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants