Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lockfile for vhs v3.13.0 #8751

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: lockfile for vhs v3.13.0 #8751

merged 1 commit into from
May 30, 2024

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented May 30, 2024 •
edited
Loading

Description

Updating our Karma dependency accidentally overwrote the VHS version in the lock. See: #8743

Specific Changes proposed

npm install and sync the lockfile to the package.json

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov Codecov
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (91e5e2d) to head (a7b795d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8751      +/-   ##
==========================================
- Coverage   83.66%   83.01%   -0.66%     
==========================================
  Files         119      119              
  Lines        7993     7993              
  Branches     1922     1922              
==========================================
- Hits         6687     6635      -52     
- Misses       1306     1358      +52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86 adrums86 merged commit 38198f6 into main May 30, 2024
13 of 15 checks passed
@adrums86 adrums86 deleted the fix-lockfile-vhs branch May 30, 2024 19:46
@kerasus kerasus mentioned this pull request Jun 21, 2024
Open
@Bitti09 Bitti09 mentioned this pull request Jun 21, 2024
Closed
@kerasus kerasus mentioned this pull request Jun 28, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 2, 2024
Open
@kerasus kerasus mentioned this pull request Jul 4, 2024
Open
@ChaosEngine ChaosEngine mentioned this pull request Jul 9, 2024
Open
@kerasus kerasus mentioned this pull request Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrums86 @misteroneill