Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes duplicate id in text track settings #8755

Merged
merged 1 commit into from
Jun 1, 2024
Merged

fix: removes duplicate id in text track settings #8755

merged 1 commit into from
Jun 1, 2024

Conversation

mister-ben
Copy link
Contributor

Description

Prevents a duplicate id in text track settings.
Fixes #8754

Specific Changes proposed

The text edge settings were erroneously duplicating the id generated for the background colour. Changes to a unique name.
Adds a general test for duplicate ids.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov Codecov
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (8729e31) to head (da1b6dd).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8755   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files         119      119           
  Lines        7993     7993           
  Branches     1922     1922           
=======================================
  Hits         6635     6635           
  Misses       1358     1358

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben merged commit a10d258 into videojs:main Jun 1, 2024
11 checks passed
@kerasus kerasus mentioned this pull request Jun 28, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 2, 2024
Open
@kerasus kerasus mentioned this pull request Jul 4, 2024
Open
@ChaosEngine ChaosEngine mentioned this pull request Jul 9, 2024
Open
@kerasus kerasus mentioned this pull request Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[8.14.1] Duplicate HTML IDs
2 participants
@mister-ben @gkatsev