Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): update Twitter X logo #8764

Merged
merged 1 commit into from
Jun 11, 2024
Merged

feat(icons): update Twitter X logo #8764

merged 1 commit into from
Jun 11, 2024

Conversation

bzizmo
Copy link
Contributor

@bzizmo bzizmo commented Jun 11, 2024 •
edited
Loading

Specific Changes proposed

  • update font version to 4.2.0 to use updated Twitter icon
  • update to Twitter X icon in SVG

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

amtins
amtins approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (f4186a0) to head (4e615a4).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8764   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files         119      119           
  Lines        7993     7993           
  Branches     1923     1923           
=======================================
  Hits         6635     6635           
  Misses       1358     1358

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-bc-dev roman-bc-dev merged commit b58b4c5 into videojs:main Jun 11, 2024
11 of 12 checks passed
@kerasus kerasus mentioned this pull request Jul 4, 2024
Open
@ChaosEngine ChaosEngine mentioned this pull request Jul 9, 2024
Open
@kerasus kerasus mentioned this pull request Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amtins amtins amtins approved these changes

@roman-bc-dev roman-bc-dev roman-bc-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bzizmo @amtins @roman-bc-dev