Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply correct styles to audio descriptions track menu items #8770

Merged
merged 4 commits into from
Jun 25, 2024
Merged

fix: apply correct styles to audio descriptions track menu items #8770

merged 4 commits into from
Jun 25, 2024

Conversation

david-hm-morgan
Copy link
Contributor

Description

Fix #8769 for mismatched track kind should be plural descriptions according to definition of AudioTrackKind
#8769

Specific Changes proposed

Pluralisation

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@welcome Welcome
Copy link

welcome bot commented Jun 14, 2024

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (2b3ffd4) to head (e8e85f7).

Files Patch % Lines
...-bar/audio-track-controls/audio-track-menu-item.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8770   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files         119      119           
  Lines        7993     7993           
  Branches     1923     1923           
=======================================
  Hits         6635     6635           
  Misses       1358     1358

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben changed the title fix 8769 plural descriptions fix: apply correct styles to audio descriptions track menu items Jun 14, 2024
mister-ben
mister-ben approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@david-hm-morgan david-hm-morgan mentioned this pull request Jun 16, 2024
Closed
@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Jun 17, 2024
amtins
amtins approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@mister-ben mister-ben added patch This PR can be added to a patch release. and removed needs: LGTM Needs one or more additional approvals labels Jun 24, 2024
@mister-ben mister-ben merged commit f701102 into videojs:main Jun 25, 2024
10 of 11 checks passed
@welcome Welcome
Copy link

welcome bot commented Jun 25, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mister-ben mister-ben mister-ben approved these changes

@amtins amtins amtins approved these changes

Assignees
No one assigned
Labels
patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AudioTrackKind misalignment re description(s)
3 participants
@david-hm-morgan @mister-ben @amtins