Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove safe-json-parse #8790

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: Remove safe-json-parse #8790

wants to merge 3 commits into from
+25 −10

Conversation

mister-ben
Copy link
Contributor

Description

Removes an old unmaintained dependency that isn't needed any more.

Specific Changes proposed

Replace safe-json-parse with JSON.parse

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.08%. Comparing base (970faa8) to head (6e4dd73).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8790      +/-   ##
==========================================
+ Coverage   83.07%   83.08%   +0.01%     
==========================================
  Files         120      120              
  Lines        8022     8021       -1     
  Branches     1925     1924       -1     
==========================================
  Hits         6664     6664              
+ Misses       1358     1357       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ravixalgorithm

This comment was marked as off-topic.

Sign in to view

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravixalgorithm ravixalgorithm ravixalgorithm approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mister-ben @ravixalgorithm