Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransientButton: WARN: removeClass was called with an element that doesn't exist #8795

Closed
phloxic opened this issue Jul 11, 2024 · 1 comment · Fixed by #8796
Closed

TransientButton: WARN: removeClass was called with an element that doesn't exist #8795

phloxic opened this issue Jul 11, 2024 · 1 comment · Fixed by #8796
Labels
needs: triage This issue needs to be reviewed

Comments

@phloxic
Copy link
Contributor

phloxic commented Jul 11, 2024

Description

Expected: player does not try to removeClass after disposal of the TransientButton.
What happens: after disposing the TransientButton, the player still tries to removeClass when you toggle controlbar visibility by hovering.

Reduced test case

https://deploy-preview-8629--videojs-preview.netlify.app/sandbox/transient-button.html

Steps to reproduce

  1. Go to demo page, open console
  2. Start playback
  3. Click transient unmute button
  4. Check removeClass was called with an element that doesn't exist warning in console, when controlbar visibility (user activity) is toggled.

Errors

No errors. Just the aforementioned warning.

What version of Video.js are you using?

v8.17.0

Video.js plugins used.

none

What browser(s) including version(s) does this occur with?

presumably in all browsers

What OS(es) and version(s) does this occur with?

presumably in all OSes
@phloxic phloxic added the needs: triage This issue needs to be reviewed label Jul 11, 2024
@mister-ben
Copy link
Contributor

Thanks for keep us honest. Fix incoming.

@mister-ben mister-ben mentioned this issue Jul 11, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: triage This issue needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure transient button event listeners are removed on dispose mister-ben/video.js
2 participants
@phloxic @mister-ben