Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Keep moving progress bar seeker causes player stuck #8804

Open
ritingliudd01 opened this issue Jul 19, 2024 · 3 comments
Open
Labels
needs: triage This issue needs to be reviewed

Comments

@ritingliudd01
Copy link

Description

When you keep dragging seeker on progress bar left and right for few seconds at https://videojs.com/advanced/?video=disneys-oceans, the player looks stuck. Checking developer tool you will find tens of requests sent in Safari of iPad Pro. It will revive until the last request returns response.

Some servers will cancel the repeated requests from the same URL with a series of corrupted .m3u8 files returned. If the browser is unable to ignore those responses and still send them to <video /> to handle, this issue will happen #8561

image

Reduced test case

https://videojs.com/advanced/?video=disneys-oceans

Steps to reproduce

  1. In Safari of iPad, go to https://videojs.com/advanced/?video=disneys-oceans;
  2. Play the default video and keep dragging the seeker on progress bar for few seconds;
  3. The video keeps loading and the player looks stuck.

Errors

No response

What version of Video.js are you using?

The version used at https://videojs.com/advanced/?video=disneys-oceans

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Safari on iPad Pro (12.9-inch) 6th generation

What OS(es) and version(s) does this occur with?

iOS 16.2

@ritingliudd01 ritingliudd01 added the needs: triage This issue needs to be reviewed label Jul 19, 2024
Copy link

welcome bot commented Jul 19, 2024

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@ritingliudd01
Copy link
Author

Suggestion

  • There should be a debounce to avoid sending request every pixel moved. Send only once when dragging seeker stops;
  • Handle the error raised from <video>. If the error is caused by a corrupted return, ignore it.

Thanks 🙏

@mister-ben
Copy link
Contributor

There'a a balance to be struck. Some people are very certain that seeking should occur as the slider is moved with immediate feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

2 participants