-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Permalink
Loading
Choose a base ref
{{ refName }}
default
Loading
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: videojs/video.js
base: v8.15.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: videojs/video.js
compare: v8.16.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 6 files changed
- 4 contributors
Commits on Jun 10, 2024
-
fix: use guid to ensure uniqueness of track setting options (#8762)
The fix for the previous issue with the new text track settings introduced that ids would be re-used across players as there was no prefix for the settings that don't have a `<label>` for their `<select>`. This change uses a generated guid for items without that label. Fixes #8761 ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for f4186a0 - Browse repository at this point
Copy the full SHA f4186a0View commit details
Commits on Jun 11, 2024
-
feat(icons): update Twitter X logo (#8764)
## Specific Changes proposed - update font version to 4.2.0 to use updated Twitter icon - update to Twitter X icon in SVG ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [ ] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [ ] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for b58b4c5 - Browse repository at this point
Copy the full SHA b58b4c5View commit details
Commits on Jun 12, 2024
-
fix: improve ts output for create logger (#8763)
## Description Typescript =< 5.2 generated better types for `log` than >= 5.3. We're on 5.5 as that has the better import syntax. Changing createLogger to use `function log()` rather than `const log = function()` outputs as before. Also updates typescript to 5.5.1 (rc) from 5.5.0 (beta). 5.2, or 5.5 with this change ``` export default log; declare const log: { (...args: any[]): void; createLogger(subName: string, subDelimiter?: string, subStyles?: string): any; createNewLogger(newName: string, newDelimiter?: string, newStyles?: string): any; levels: any; level(lvl?: "info" | "error" | "all" | "debug" | "warn" | "off"): string; history: { (): any[]; filter(fname: string): any[]; clear(): void; disable(): void; enable(): void; }; error(...args: any[]): any; warn(...args: any[]): any; debug(...args: any[]): any; }; export const createLogger: (subName: string, subDelimiter?: string, subStyles?: string) => any; //# sourceMappingURL=log.d.ts.map% ``` 5.3+, without this change ``` export default log; declare function log(...args: any[]): void; declare namespace log { } export const createLogger: (subName: string, subDelimiter?: string, subStyles?: string) => any; //# sourceMappingURL=log.d.ts.map% ``` ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for 86ff612 - Browse repository at this point
Copy the full SHA 86ff612View commit details -
Configuration menu - View commit details
-
Copy full SHA for 864074d - Browse repository at this point
Copy the full SHA 864074dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b468dd - Browse repository at this point
Copy the full SHA 6b468ddView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.15.0...v8.16.0