Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: videojs/video.js Loading
base: v8.15.0
Choose a base ref
...
head repository: videojs/video.js Loading
compare: v8.16.0
Choose a head ref
  • 5 commits
  • 6 files changed
  • 4 contributors

Commits on Jun 10, 2024

  1. fix: use guid to ensure uniqueness of track setting options (#8762)

    The fix for the previous issue with the new text track settings
    introduced that ids would be re-used across players as there was no
    prefix for the settings that don't have a `<label>` for their
    `<select>`.
    
    This change uses a generated guid for items without that label.
    Fixes #8761
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [x] Change has been verified in an actual browser (Chrome, Firefox,
    IE)
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [x] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    mister-ben committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f4186a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. feat(icons): update Twitter X logo (#8764)

    ## Specific Changes proposed
    - update font version to 4.2.0 to use updated Twitter icon
    - update to Twitter X icon in SVG
    
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [ ] Change has been verified in an actual browser (Chrome, Firefox,
    IE)
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [ ] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    bzizmo committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b58b4c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. fix: improve ts output for create logger (#8763)

    ## Description
    Typescript =< 5.2 generated better types for `log` than >= 5.3. We're on
    5.5 as that has the better import syntax.
    Changing createLogger to use `function log()` rather than `const log =
    function()` outputs as before.
    
    Also updates typescript to 5.5.1 (rc) from 5.5.0 (beta).
    
    5.2, or 5.5 with this change
    ```
    export default log;
    declare const log: {
        (...args: any[]): void;
        createLogger(subName: string, subDelimiter?: string, subStyles?: string): any;
        createNewLogger(newName: string, newDelimiter?: string, newStyles?: string): any;
        levels: any;
        level(lvl?: "info" | "error" | "all" | "debug" | "warn" | "off"): string;
        history: {
            (): any[];
            filter(fname: string): any[];
            clear(): void;
            disable(): void;
            enable(): void;
        };
        error(...args: any[]): any;
        warn(...args: any[]): any;
        debug(...args: any[]): any;
    };
    export const createLogger: (subName: string, subDelimiter?: string, subStyles?: string) => any;
    //# sourceMappingURL=log.d.ts.map%
    ```
    
    5.3+, without this change
    ```
    export default log;
    declare function log(...args: any[]): void;
    declare namespace log { }
    export const createLogger: (subName: string, subDelimiter?: string, subStyles?: string) => any;
    //# sourceMappingURL=log.d.ts.map%
    ```
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [x] Change has been verified in an actual browser (Chrome, Firefox,
    IE)
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [x] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    mister-ben committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    86ff612 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    864074d View commit details
    Browse the repository at this point in the history
  3. 8.16.0

    adrums86 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    6b468dd View commit details
    Browse the repository at this point in the history
Loading