Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: videojs/video.js Loading
base: v8.16.0
Choose a base ref
...
head repository: videojs/video.js Loading
compare: v8.16.1
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Jun 23, 2024

  1. chore: Update typescript to 5.5.2 (#8776)

    ## Description
    Update to release of Typescript 5.5 (5.5.2) from rc (5.5.1). Diff shows
    no changes in types output.
    mister-ben committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    fa9c41c View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. fix: enable keyboard controls on menu items (#8777)

    ## Description
    
    This fix addresses an issue that was introduced in this
    [refactor](35de64c#diff-9fd94576fe3b609171a426feb961b0954d70c8c14e598024d49ae9c8836a71ca).
    At the moment, all key down events that are supposed to interact with
    the `menu-item` component are now being ignored, meaning you are unable
    to interact with most of the menu items in the control bar (e.g.
    captions settings). This PR fixes that by only ignoring key down events
    that are normally ignored by the `menu-item`.
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [ ] Change has been verified in an actual browser (Chrome, Firefox,
    IE)
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [ ] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    usmanonazim committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    04b9bb2 View commit details
    Browse the repository at this point in the history
  2. 8.16.1

    usmanonazim committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2b3ffd4 View commit details
    Browse the repository at this point in the history
Loading