-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Permalink
Loading
Choose a base ref
{{ refName }}
default
Loading
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: videojs/video.js
base: v8.16.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: videojs/video.js
compare: v8.17.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 16 files changed
- 5 contributors
Commits on Jun 25, 2024
-
fix: apply correct styles to audio descriptions track menu items (#8770)
Configuration menu - View commit details
-
Copy full SHA for f701102 - Browse repository at this point
Copy the full SHA f701102View commit details
Commits on Jul 6, 2024
-
feat: Adds a transient button component (#8629)
## Description Adds a `TransientButton` component for the types of button that are shown on top of the video briefly during playback and reappear when there is user activity. e.g. Unmute buttons, skip intro. It aims is to be a generic button type to be extended. Some basic styles are provided but kept light to not complicate customisation. It's important to insert a transient button before the control bar for the tab order to make sense. _Optionally_ takes focus when shown. ## Specific Changes proposed Adds `TransientButton` component. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [x] Unit Tests updated or fixed - [ ] Docs/guides updated - [x] Example: https://deploy-preview-8629--videojs-preview.netlify.app/sandbox/transient-button.html - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for 1afe504 - Browse repository at this point
Copy the full SHA 1afe504View commit details -
fix(middleware): cache grows even if no middleware created (#8674)
## Description See issue #8653 ## Specific Changes proposed When in `middleware.js` the function `clearCacheForPlayer` runs, before setting a value to null in middlware caches, it checks if the key exists in the first place. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [x] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [x] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [ ] Reviewed by Two Core Contributors --------- Co-authored-by: Giuseppe Piscopo <g.piscopo@braincrumbz.com> Co-authored-by: mister-ben <git@misterben.me>
Configuration menu - View commit details
-
Copy full SHA for 6221a8f - Browse repository at this point
Copy the full SHA 6221a8fView commit details -
fix(types): fix and improve component ready callback definition (#8766)
- Removes erroneous `@return {Component}` from `ReadyCallback` in Component - Remove `@this {Component}` from `ReadyCallback` in Component, because this is not accurate for classes that extend Component - Adds `@returns {void}` to `ReadyCallback` in Component - Produces a more accurate typedef - Isn't strictly accurate in jsdoc/javascript but does this matter since it's well understood. Absence of `@return` is interpreted by tsc as returning `{any}`, `@returns {undefined}` would require an explicit `return undefined` in ts. - Adds a `{PlayerReadyCallback}` in Player with `@this {Player}` used in the `new Player()` and `videos()` constructors. - Are we ok adding this new typedef - Is inconsistent with `player.ready()` which uses `ReadyCallback` without `@this` - but this can't be changed without adding an otherwise unnecessary override just to pander to tsc. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for 970faa8 - Browse repository at this point
Copy the full SHA 970faa8View commit details
Commits on Jul 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51b4670 - Browse repository at this point
Copy the full SHA 51b4670View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.16.1...v8.17.0