Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: videojs/video.js Loading
base: v8.17.0
Choose a base ref
...
head repository: videojs/video.js Loading
compare: v8.17.1
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 14, 2024

  1. fix: ensure transient button event listeners are removed on dispose (#…

    …8796)
    
    ## Description
    Transient button sets an event listener on the player directly instead
    of on itself, which doesn't get cleaned up when disposed.
    Fixes #8795
    
    ## Specific Changes proposed
    Call `on` on the component with player as the first arg, instead of
    calling `on` on the player directly.
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [x] Change has been verified in an actual browser (Chrome, Firefox,
    IE)
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [x] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    mister-ben committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    0a836e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. 8.17.1

    mister-ben committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e78bcc7 View commit details
    Browse the repository at this point in the history
Loading