videojs / video.js

85%

master: 85%

LAST BUILD ON BRANCH fix-back-seek

branch: fix-back-seek

CHANGE BRANCH

x

Reset

• fix-back-seek
• es6ification
• master
• v5.0.0-2
• v5.0.0-3
• v5.0.0-4
• v5.0.0-5
• v5.0.0-6
• v5.0.0-7
• v5.0.0-8
• v5.0.0-9
• v5.0.0-10
• v5.0.0-11
• v5.0.0-12
• v5.0.0-13
• v5.0.0-14
• v5.0.0-15
• v5.0.0-17
• v5.0.0-33
• v5.0.0-rc.1
• v5.0.0-rc.3
• v5.0.0-rc.5
• v5.0.0-rc.8
• v5.0.0-rc.11
• v5.0.0-rc.13
• v5.0.0-rc.16
• v5.0.0-rc.17
• v5.0.0-rc.20
• v5.0.0-rc.22
• v5.0.0-rc.24
• v5.0.0-rc.62
• v5.0.0-rc.63
• v5.0.0-rc.64
• v5.0.0-rc.66
• v5.0.0-rc.70
• v5.0.0-rc.71
• v5.0.0-rc.72
• v5.0.0-rc.73
• v5.0.0-rc.74
• v5.0.0-rc.75
• v5.0.0-rc.76
• v5.0.0-rc.78
• v5.0.0-rc.79
• v5.0.0-rc.80
• v5.0.0-rc.81
• v5.0.0-rc.82
• v5.0.0-rc.83
• v5.0.0-rc.86
• v5.0.0-rc.87
• v5.0.0-rc.88
• v5.0.0-rc.89
• v5.0.0-rc.90
• v5.0.0-rc.91
• v5.0.0-rc.92
• v5.0.0-rc.93
• v5.0.0-rc.94
• move-gruntjs
• v5.0.0-rc.97
• v5.0.0-rc.100
• v5.0.0-rc.101
• v5.0.0-rc.103
• v5.0.0-rc.104
• stable
• v5.0.0
• v5.2.0
• patch
• v5.2.1
• v5.2.2
• v5.2.3
• v5.2.4
• v5.3.0
• 4.12.0
• v5.4.0
• v5.4.1
• v5.4.3
• v5.4.4
• v5.4.5
• v5.4.6
• v5.5.0
• v5.5.1
• v5.5.2
• v5.5.3
• v5.7.0
• v5.7.1
• v5.8.0
• v5.8.1
• v5.8.3
• fix-ie8-tests
• v5.8.5
• v5.8.6
• v5.9.0-1
• fix-ie8-tag
• pr3212
• v5.8.7
• v5.8.8
• v5.9.0
• v5.9.0-2
• fix-tests-ie
• v5.9.1
• v5.9.2
• video-audio-tracks
• clear-currentsource-loadstart
• v5.10.1
• v5.10.2
• v5.10.3
• v5.10.4
• fix-ie8-videojs
• v5.10.5
• v5.10.6
• v6.1.2
• v5.10.7
• lang-test-issues
• v5.11.0
• vjsstandard-core
• v5.10.8
• v5.11.1
• v5.11.2
• greenkeeper-karma-qunit-1.2.0
• new-build
• greenkeeper-karma-1.2.0
• revert-qunit
• greenkeeper-grunt-concurrent-2.3.1
• v5.11.4
• greenkeeper-uglify-js-2.7.2
• greenkeeper-uglify-js-2.7.3
• pr/3547
• requirable
• require-tests
• greenkeeper-karma-chrome-launcher-2.0.0
• ie8-test-fix
• greenkeeper-babel-cli-6.14.0
• greenkeeper-babel-register-6.14.0
• v5.11.5
• refactor-tts-complete
• v5.11.6
• v5.13.0
• v5.12.1
• greenkeeper-grunt-contrib-cssmin-1.0.2
• greenkeeper-babel-plugin-transform-runtime-6.12.0
• greenkeeper-babel-plugin-transform-runtime-6.15.0
• greenkeeper-karma-browserstack-launcher-1.1.1
• greenkeeper-karma-1.3.0
• greenkeeper-sinon-1.17.6
• greenkeeper-grunt-shell-2.0.0
• v5.11.7
• v5.12.2
• greenkeeper-babel-preset-es2015-6.16.0
• greenkeeper-babel-register-6.16.0
• greenkeeper-babel-register-6.16.3
• greenkeeper-karma-qunit-1.2.1
• refactor-tts
• greenkeeper-babel-cli-6.16.0
• v5.12.3
• v5.12.4
• v5.12.5
• greenkeeper-uglify-js-2.7.4
• naked-createEl
• fix-minified-comments
• greenkeeper-babel-cli-6.18.0
• remove-sourcemaps
• greenkeeper-babel-preset-es2015-6.18.0
• greenkeeper-babel-register-6.18.0
• greenkeeper-babel-runtime-6.18.0
• v5.11.9
• v5.12.6
• greenkeeper-webpack-1.13.3
• auto-cleaup-texttracks
• greenkeeper-grunt-shell-2.1.0
• bug/fix-ie8-unit-test
• greenkeeper-grunt-accessibility-5.0.0
• greenkeeper-karma-detect-browsers-2.2.1
• greenkeeper-karma-detect-browsers-2.2.2
• pin-karma-detect-browsers
• greenkeeper-grunt-github-releaser-0.1.18
• remove-el-class-safari
• v5.13.1
• greenkeeper-karma-detect-browsers-2.2.3
• fix-flash
• revert-flash-cache
• v5.13.2
• refactor/text-track-api
• always-emulate-captions
• fix-custom-player-test
• v5.14.0
• pr/3833
• browserstack-edge
• silence-guru-meditation
• v5.14.1
• middleware
• remove-seeking-on-src-change
• player-div-ingestion
• fix-console-log-tests
• vjs-hooks-tests
• patch-can-play-type
• fix-remote-track-logs
• hooks-logs
• greenkeeper/update-all
• greenkeeper/ghooks-2.0.0
• v5.15.0
• fix-ie8
• v5.15.1
• greenkeeper/lodash-4.17.3
• greenkeeper/sinon-1.17.7
• greenkeeper/lodash-4.17.4
• v5.0.0-16
• v5.17.0

Build # 4864

Build Type

push

travis-ci

Committed by gkatsev

Commit Message

fix(seeking): don't always pause in mouse down

In chrome 55, something changed which introduced a bug in videojs where
if you seeked back, it wouldn't work. This is because we always paused
the video in the mousedown handler.

Instead, we should create a timer for pausing that is cleared in the
mouseup handler or in the mouse move handler. This is so that if someone
is seeking by clicking and waiting the video pauses. As soon as we start
moving and we get a mousemove event, we can know that it's safe to pause
as well.

Fixes #3839.

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

5595 of 6554 relevant lines covered (85.37%)

1494.78 hits per line